Add output_format do video datasets and readers #6061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
commented
May 20, 2022
datumbox
reviewed
May 20, 2022
9 tasks
datumbox
approved these changes
May 23, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
Summary: Co-authored-by: Vasilis Vryniotis <[email protected]> Reviewed By: NicolasHug Differential Revision: D36760918 fbshipit-source-id: bfaa11b43cb0ebffb41b0e24fef1b6b65b6deef4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5952 (review)
This PR adds a new
output_formatto all video datasets, as well asVideoClips()andread_video(). The default is BC, so it corresponds to:TCHWfor KineticsTHWCfor everything else.This is far from ideal, but this is the only way for users to have a consistent experience in torchvision. Right now, Kinetics is an outlier. For ref, the decision to have Kinetics follow the
TCHWformat comes from #3680 (comment).